feat: use unsigned integers only #8

kyriediculous · 2024-04-12T14:45:19Z

We can use our formula below with unsigned integers only

(((u + x)*k - U + u)*((U + x)/L)**k + (-k*u + U - u)*(U/L)**k)*(S + U)/(k*(1 + k)*(s + u))

in this formula (-k*u + U -u) can be rewritten as U-(k+1)*u

if U < (k+1*u) then we must do (k+1)*u - Uand subtract that from the first part of the sum in the nominator
else we use the initial formula

0xnmna · 2024-04-12T16:14:21Z

I suppose you mean if U < (k+1)*u instead of U < (k+1*u)?

So to clarify:

a = ((u + x)*k - U + u)  *  ((U + x)/L)**k
c = (S + U) / (k*(1 + k)*(s + u))

if ( U >= (k+1)*u ) {
    b = ( U - u(k+1) ) * (U/L)**k
    result = (a + b)*c

} else {
    b = ( u(k+1) - U ) * (U/L)**k
    result = (a - b)*c
}

Right?

src/Swap.sol

Co-authored-by: 0xbvda <[email protected]>

feat: use unsigned integers only

48d0dba

kyriediculous requested review from nmboavida and adsiko April 12, 2024 14:45

fix: Factory size

d443bab

0xnmna requested review from 0xnmna and removed request for nmboavida April 12, 2024 16:16

0xnmna reviewed Apr 12, 2024

View reviewed changes

src/Swap.sol Outdated Show resolved Hide resolved

fix: correct comment

b320893

Co-authored-by: 0xbvda <[email protected]>

kyriediculous merged commit a7360d0 into main Apr 12, 2024
2 checks passed

kyriediculous deleted the nv/unsigned-only branch April 12, 2024 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use unsigned integers only #8

feat: use unsigned integers only #8

kyriediculous commented Apr 12, 2024 •

edited

Loading

0xnmna commented Apr 12, 2024

feat: use unsigned integers only #8

feat: use unsigned integers only #8

Conversation

kyriediculous commented Apr 12, 2024 • edited Loading

0xnmna commented Apr 12, 2024

kyriediculous commented Apr 12, 2024 •

edited

Loading